feat: add blob/get #126
feat: add blob/get #126
Conversation
Co-authored-by: Vasco Santos <santos.vasco10@gmail.com>
w3-blob.md
Outdated
| } | ||
|
|
||
| type GetBlobOk = { | ||
| blob: blob |
There was a problem hiding this comment.
I saw in the implementation you add the cause here. And I actually think that is nice, so also should be in the spec response
There was a problem hiding this comment.
makes perfect sense! adding it
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
Co-authored-by: Alan Shaw <alan.shaw@protocol.ai>
|
This might be controversial, but I wonder if we could simply return return pointer to the receipt and let client fetch all the details. The rational here is that adding a blob is a long running task and has state that moves from initiated to in progress to complete described by individual tasks. I think it would make most sense to do that. That is not to say we should block shipping blob/get on this, but perhaps it would be better to not spec out in way that requires state checks on the server. Please note that I'm not advocating for the above solution, it's really more of a question than prescription. |
|
In the implementation PR I have proposed adding version suffix to the capability storacha/w3up#1484 (review) I think it would make sense to add this changes to the spec with version suffix also maybe with some note that likely we'll deprecate it in the future in favor of suffixes-less version that just returns receipt id. |
Adds support for `blob/get` as defined in storacha/specs#126 --------- Co-authored-by: Vasco Santos <santos.vasco10@gmail.com> Co-authored-by: Irakli Gozalishvili <contact@gozala.io>
w3-blob.md
Outdated
| message: string | ||
| } | ||
|
|
||
| type Blob = { /* ??? */ } |
There was a problem hiding this comment.
I think you need to fill this out - it's multihash and size right?
There was a problem hiding this comment.
good point. completely missed it
Adds the
blob/getcapability spec which is analogous to #82